Introduce 'USE_COMPILER_DEFAULT_LIBC' cmake option for switching from jerry-libc to a libc, provided by compiler #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruben-ayrapetyan
added
enhancement
ruben-ayrapetyan
force-pushed
the
use-compiler-default-libc-cmake-option-dev
branch
from
238c4df to
d6b9f2c
Compare
ruben-ayrapetyan
force-pushed
the
use-compiler-default-libc-cmake-option-dev
branch
2 times, most recently
from
0baccab to
ecc0e20
Compare
|
Good to me |
ruben-ayrapetyan
force-pushed
the
use-compiler-default-libc-cmake-option-dev
branch
from
ecc0e20 to
192a85d
Compare
|
Good to me |
| $(error EXTERNAL_LIBC_INTERFACE should not be specified in case compiler's default libc is used) | ||
| endif | ||
| else | ||
| EXTERNAL_LIBC_INTERFACE ?= $(shell pwd)/third-party/nuttx/include |
There was a problem hiding this comment.
I think after #330 this isn't needed anymore.
There was a problem hiding this comment.
Yes, seems so. I'll rebase to current master.
ruben-ayrapetyan
force-pushed
the
use-compiler-default-libc-cmake-option-dev
branch
from
192a85d to
718c69f
Compare
|
lgtm |
|
|
…o a libc, provided by compiler. JerryScript-DCO-1.0-Signed-off-by: Ruben Ayrapetyan [email protected]
egavrin
force-pushed
the
use-compiler-default-libc-cmake-option-dev
branch
from
718c69f to
393d693
Compare
seanshpark
added a commit
to seanshpark/jerryscript
that referenced
this pull request
Jul 9, 2015
Related with jerryscript-project#331 JerryScript-DCO-1.0-Signed-off-by: SaeHie Park [email protected]
seanshpark
added a commit
to seanshpark/jerryscript
that referenced
this pull request
Jul 12, 2015
Related with jerryscript-project#331 JerryScript-DCO-1.0-Signed-off-by: SaeHie Park [email protected]
LaszloLango
pushed a commit
to LaszloLango/jerryscript
that referenced
this pull request
Jul 14, 2015
Related with jerryscript-project#331 JerryScript-DCO-1.0-Signed-off-by: SaeHie Park [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.